Refactoring Radius 2.0 #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apashkov-ext
requested changes
Feb 5, 2026
| services.AddSingleton(appVars); | ||
| } | ||
|
|
||
| private static void AddLdapBindNameFormation(IServiceCollection services) |
Collaborator
There was a problem hiding this comment.
Предлагаю эти вещи раскидать по модулям, чтобы сделать честными фичами и избавиться от DI hell
|
|
||
| namespace Multifactor.Radius.Adapter.v2.Application.Features.Ldap.Ports; | ||
|
|
||
| public interface ILdapAdapter |
Collaborator
There was a problem hiding this comment.
Это не порт, а толстый неудобный интерфейс. А еще в папке Features/Ldap не нашел собственно фичи. Есть только этот интерфейс имодели
src/Multifactor.Radius.Adapter.v2.Infrastructure/Configurations/Models/ConfigurationFile.cs
Outdated
Show resolved
Hide resolved
src/Multifactor.Radius.Adapter.v2.Infrastructure/Configurations/Reader/ConfigurationReader.cs
Outdated
Show resolved
Hide resolved
src/Multifactor.Radius.Adapter.v2.Infrastructure/Configurations/Reader/ConfigurationReader.cs
Show resolved
Hide resolved
...tor.Radius.Adapter.v2.Infrastructure/Configurations/Reader/ConfigurationBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,45 @@ | |||
| namespace Multifactor.Radius.Adapter.v2.Infrastructure.Adapters.Multifactor.Http; | |||
|
|
|||
| public class ActivityContext | |||
Collaborator
There was a problem hiding this comment.
по хорошему стоит от него отказаться в пользу OpenTelemtry
src/Multifactor.Radius.Adapter.v2.Infrastructure/Logging/SerilogLoggerFactory.cs
Outdated
Show resolved
Hide resolved
src/Multifactor.Radius.Adapter.v2.Infrastructure/Logging/SerilogLoggerFactory.cs
Outdated
Show resolved
Hide resolved
src/Multifactor.Radius.Adapter.v2.Infrastructure/Logging/SerilogLoggerFactory.cs
Outdated
Show resolved
Hide resolved
src/Multifactor.Radius.Adapter.v2.Infrastructure/Logging/StartupLogger.cs
Outdated
Show resolved
Hide resolved
| { | ||
| contentBytes = RadiusPasswordProtector.Encrypt(sharedSecret, authenticator, contentBytes); | ||
| } | ||
| else if (attributeDefinition.Code == 80) // Message-Authenticator |
src/Multifactor.Radius.Adapter.v2.Infrastructure/Radius/Builders/RadiusPacketBuilder.cs
Outdated
Show resolved
Hide resolved
| private readonly IRadiusDictionary _radiusDictionary; | ||
| private readonly ILogger<RadiusAttributeParser> _logger; | ||
| const int VendorSpecific = 26; | ||
| const int MessageAuthenticator = 80; |
Collaborator
There was a problem hiding this comment.
снова те же константы
src/Multifactor.Radius.Adapter.v2.Infrastructure/Radius/Parsers/RadiusAttributeParser.cs
Outdated
Show resolved
Hide resolved
| var content = ParseContentBytes( | ||
| vendorContentBytes, | ||
| vendorAttribute.Type, | ||
| 26, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new: